search

osrg / gobgp

BGP implemented in the Go Programming Language
https://osrg.github.io/gobgp/
Apache License 2.0
3.66k stars 699 forks source link

Fix accepted/rejected adj-in commands #2823

Closed myaut closed 2 months ago

myaut commented 4 months ago

Original logic for accepted/rejected commands was removed in 2dbca9e29a6813f2df53261ffaa59b9439c13fdd when IN policies were deprecated.

Then 7e5eb10a8470826a14ec225cf6a7264785ea3603 added support for server-side filtering based on IMPORT polcies, but CLI support wasn't added. Repurposing accepted/rejected commands for this.

fujita commented 4 months ago

https://github.com/osrg/gobgp/commit/7e5eb10a8470826a14ec225cf6a7264785ea3603 wasn't merged? What do you mean?

myaut commented 4 months ago

7e5eb10a8470826a14ec225cf6a7264785ea3603 contains only server-side changes. This PR contains CLI support for it.

bayrinat commented 2 months ago

@fujita gentle ping

fujita commented 2 months ago

I don't understand the situation. The server-side code isn't merged. Why we need to merge this pull request to add CLI support for that?

myaut commented 2 months ago

Ugh, sorry for the confusion. The correct commit is bec61c4f38344febda7495a35afa02061bb2880b I guess - the one that adds a simple EnableFiltered to the server.

This PR sets said flag in the accepted/rejected commands.

fujita commented 2 months ago

Pushed, thanks!