search

osrg / gobgp

BGP implemented in the Go Programming Language
https://osrg.github.io/gobgp/
Apache License 2.0
3.66k stars 699 forks source link

Use configured local address over the one that is taken from the BGP session #2827

Closed barlev-eddie closed 2 months ago

barlev-eddie commented 3 months ago

Use configured local address over the one that is taken from the BGP TCP connection.

This is needed in cases when using VRFs over GENEVE Tunnels where we bind the listening address to one internal IP for security reasons. Without this fix the local address was overridden with the listening address resulting in wrong nexthop advertisement.

fujita commented 2 months ago

Pushed, thanks. IPv4Unspecified() is better than 0.0.0.0, I guess though.

barlev-eddie commented 2 months ago

@fujita , thanks for handling it. I forgot about it due to family and work load. Do u want me to open another PR to change to the IPv4Unspecified() call ?

fujita commented 2 months ago

Yeah, thanks.