search

osrg / ryu-book

Apache License 2.0
57 stars 40 forks source link

Korean translation #6

Closed ianychoi closed 10 years ago

ianychoi commented 10 years ago

Hello.

I have completed first Korean translation. I orginally used kotex (Korean specific latex package), but after I saw peterui's commit, now I use XeLaTeX. So creating PDF might have no problem for you.

Please review my pull request.

Thank you so much,

fujita commented 10 years ago

Great, thanks a lot!

The author of the following commit looks strange. Do you want to fix?

https://github.com/ianychoi/ryu-book/commit/67f1321d7b4fad31a2ab2e0be7a8e7f122b82a0a

ianychoi commented 10 years ago

Hi @fujita ,

Yes. I executed reset, commit, and push. Could you see it again?

ianychoi commented 10 years ago

@fujita ,

Sure. This was because I originally thought that README.md in root directory should include specific information. However, as you mentioned, after I saw README.md in zh_tw, I changed README.md in root directory to be general, and included README.md in 'ko' directory.

Please check this: https://github.com/ianychoi/ryu-book/blob/localization/korean/ko/README.md

Thanks!

fujita commented 10 years ago

Thanks! Please rebase. We try to avoid 'merge commit'. Also you can drop some of the changes you made to README.md in the top directory.

ianychoi commented 10 years ago

@fujita

In fact, I am not well familiar with git, but I have followed some instructions by referring to a few web sites.

Could you review it again? Is it okay?

fujita commented 10 years ago

The repository was not rebased properly. I've just committed your Korean edition work in a single commit. Please check the latest git head. Thanks a lot!