Closed osrsbox closed 4 years ago
About to push an update to resolve this issue. After putting in a lot of time to try and solve this, there are still a couple of issues/quirks to the solution. The following changes have been made:
generate_items_cache_data.py
to find stacked
itemsgenerate_items_cache_data.py
to label items with new stacked
propertydata/schemas
submodule to include new stacked
propertyosrsbox/items_api/item_properties
to include new stacked
propertybuilders/items
to include new stacked
property and handle missing item icons (use linked ID)The remaining problems are:
Closed in a504a83fe81868fc73ce2766e14208d8dd68e2ca.
A new bug was discovered in the item database where items that are stackable (e.g.,
Coins
) that also have graphical icon differences do not have their stackable variants in the database. Take the example ofCoins
with the item ID of995
. There is no additional item IDs in the database that cover the variations to the originalCoins
item... in different stacked amounts.Identifying stacked items: It turns out that an
ItemDefinition
has two properties to identify an item with stacked variants:countObj
andcountCo
. Examples for theCoins
item is displayed below:The
countObj
property provides the variant item IDs, and thecountCo
property seems (at a best guess) to be a variable for the amount of a specific item to be represented by a different object.Including stacked items: To include these items in the database, the following points need to be performed:
generate_items_cache_data.py
script needs to be update to parse thecountObj
andcountCo
properties.stacked
orstacked_variant
) needs to be added and hold a boolean variable... or the item ID of the original item.