search

osrsbox / osrsbox-db

A complete and up-to-date database of Old School Runescape (OSRS) items, monsters and prayers
https://www.osrsbox.com/projects/osrsbox-db/
GNU General Public License v3.0
224 stars 82 forks source link

Issue with Verzik Vitur data. #194

Open tyler-shaw opened 3 years ago

tyler-shaw commented 3 years ago

When using the API, I noticed that the various forms of Verzik Vitur appear to have incorrect data.

All 3 forms have the same stats with the exception of their combat level.

Relevant links:

https://api.osrsbox.com/monsters/8370 https://api.osrsbox.com/monsters/8372 https://api.osrsbox.com/monsters/8374

Thanks

osrsbox commented 3 years ago

Hey @tyler-shaw - I had another look at this issue today. Looked at the wiki data, then my data. The problem is that the wiki uses a Switch infobox for the toggle of this NPC/monster. It is one of the very few (haven't counted, but judging off experience) wiki pages that does this. It seems this is used because there is an NPC version (from the quest) and a monster version (from TOB) that are on the same page - and my "parser" cannot handle these. At the moment, it seems like a lot of work to add in Switch infobox parsing for a few outliers. But I will leave this issue open, and keep thinking of how to fix this.

tyler-shaw commented 3 years ago

Thanks for the response.

Didn't want to make a new issue but adding another problematic monster here just for the record.

Monster ID 10589 (Urium Shade) shows in the NPC search tool but the data is missing from the API. https://api.osrsbox.com/monsters/10589

osrsbox commented 3 years ago

Hey @tyler-shaw - thanks for reporting this. I am at a complete loss as to whats happening at the moment! Documenting some of this following for myself to try resolve:

Maybe today's update will solve this after a database rebuilt. Will keep an eye on it, and see what is happening.

EDIT...

osrsbox commented 3 years ago

Just an update. Solved! The regex used for the API for monster ID was set to maximum of a 4 digit string. So any monster with an ID over 10,000 was not being parsed. When I first wrote that part, the ID only went up to 7000 or so. But it slowly increased over time. Thanks for reporting this @tyler-shaw - glad to get this bug fixed.