search

osrsbox / osrsbox-db

A complete and up-to-date database of Old School Runescape (OSRS) items, monsters and prayers
https://www.osrsbox.com/projects/osrsbox-db/
GNU General Public License v3.0
223 stars 80 forks source link

Npc API Cave Horror uses wrong id for Black Mask drop #204

Closed Justlfied closed 3 years ago

Justlfied commented 3 years ago

The item ID for black mask the API returns is 8921 which is the normal black mask but Cave Horrors drop Black Mask (10) which uses item ID 8901

osrsbox commented 3 years ago

Hey @Justlfied - just got a some spare time to look into this issue, and you are right. It seems as though the item returned from an OSRS wiki SMW query for the Cave Horror (and Cave abomination) returns Black mask uncharged version, instead of Black mask (10) -- as it should be. So when I do an item lookup to get the ID (using the name Black mask) the wrong item ID is returned.

What I might do, is just hard code the Black mask drop to be Black mask (10) instead. I don't like hard coding stuff like this, but seems safe in this instance. Will make the change during the next in-game update. So it should be fixed by Thursday next week (2021-02-11) approximately.

Thanks for reporting the issue. It is nice to fix stuff like this.