search

osrsbox / osrsbox-db

A complete and up-to-date database of Old School Runescape (OSRS) items, monsters and prayers
https://www.osrsbox.com/projects/osrsbox-db/
GNU General Public License v3.0
223 stars 80 forks source link

Missing Alchemical Hydra from monsters_api #208

Closed BossHuso closed 3 years ago

BossHuso commented 3 years ago

Alchemical Hydra has 9 known NPC IDs, seems the following 2 IDs are missing in the API:

8622
8634

Did a Hydra trip and debugged the NPC, getting ID 8622 with every kill, so every call I'm making to the API returns a 404 right now.

osrsbox commented 3 years ago

Hey @BossHuso - had a quick look at this issue this morning, especially the ID 8622 (as that is a valid monster ID on the wiki). After a some digging around my data, then looking at the wiki, then looking at the cache data - it seems like the "monster" 8622 is not included as the NPC is not attackable (based on right click options). Looking at the wiki data - they have 8622 as the "Two heads" version. Trying to remember if that version has a non-attackable "phase" and that's why it is not included (it's been like 6 months since I did this task). Any ideas?

Pretty sure I can just made a hardcoded exception for this NPC ID and include it in the database and API. I don't think I will include 8634, only 8622. As the wiki has no data and doesn't list the 8634 version. Will work on getting this added in the next update as it seems worthy of including.

BossHuso commented 3 years ago

@osrsbox Thank you for the quick response. In my tests I only ran into ID 8622, so that seems good enough :)

Not attackable could be right, since Hydra has different phases, I'm guessing his ID swaps with every phase. His last phase is "two-headed" indeed. Only thing I could imagine is the ID being changed to 8622 once his last phase is killed (which could explain the not attackable part).

osrsbox commented 3 years ago

Cool - thanks for the insight. I forgot that the two-headed version was the last phase, which is good info. Anyway, I will add in a specific exception to include 8622. Should be able to get it in the next release without too much hassle (which is usually just after the in-game update). Thanks for reporting the bug - love getting small, kind of obscure problems fixed!

MathieuDR commented 3 years ago

Thanks for the quick response @osrsbox!

osrsbox commented 3 years ago

This will be added in today's update, and will be automatically closed. Please reopen if there are any issues.