osrsbox / osrsbox-db

A complete and up-to-date database of Old School Runescape (OSRS) items, monsters and prayers
https://www.osrsbox.com/projects/osrsbox-db/
GNU General Public License v3.0
224 stars 82 forks source link

Broodoo Shield - Incorrect buy_limit #220

Open tyler-shaw opened 3 years ago

tyler-shaw commented 3 years ago

Hello. I've got a script that monitors changes in the data from the API and I noticed that Broodoo shields all have buy limits of null now. Previously, they were correctly listing the buy limit as 125.

I double checked the wiki, and each Broodoo shield still appears to be listing 125 as the buy limit.

For example, here's the green one on the API: https://api.osrsbox.com/items/6235 And the respective page on the wiki: https://oldschool.runescape.wiki/w/Broodoo_shield_(green)#Uncharged

Thanks!

osrsbox commented 3 years ago

Hey @tyler-shaw - after a quick look... yes you are correct. The uncharged variant should have a buy limit of 125. The charged version with 10 charges should also have a buy limit, but it also doesn't: https://api.osrsbox.com/items/6215 I get the buy limit data from the following wiki page: https://oldschool.runescape.wiki/w/Grand_Exchange/Buying_limits. Then match on item name, or wiki name Looks like the manes in that table do not match the names used in the other wiki pages etc. Will have a little think about how to solve this without hardcoding heaps of stuff.