search

osrsbox / osrsbox-db

A complete and up-to-date database of Old School Runescape (OSRS) items, monsters and prayers
https://www.osrsbox.com/projects/osrsbox-db/
GNU General Public License v3.0
224 stars 82 forks source link

Dumped monster drops incorrect for some, such as npc 252 (Black dragon) #223

Closed MgtMadness25 closed 4 months ago

MgtMadness25 commented 3 years ago

Shows only 2 drops but the previous Osrsbox versions has 60 drops https://oldschool.runescape.wiki/w/Black_dragon#Level_227

MgtMadness25 commented 3 years ago

Like this branch has correct Black dragon drops it seems https://github.com/osrsbox/osrsbox-db/blob/9c94a670b7bd9afe97f4cb978468de5387a7d8bf/docs/monsters-json/252.json

MgtMadness25 commented 3 years ago

I also noticed that some npcs on the json dumps have the "Rare and gem drop table" included and others do not.

Great work with the entire project by the way, really appreciate your time.

osrsbox commented 3 years ago

Hey @MgtMadness25 - the next update should fix this problem. The wiki changed how they handled drops and I didn't notice in the last update. Regarding the rare drop table issue - this is known and is something I have never got around to fixing. I am barely keeping the project updated due to other commitments, so unlikely that this issue will get fixed, as there are other priorities - sorry!

FYI - the drop variable used for the Black Dragon is incorrect on the wiki. Hopefully it gets fixed by the next time I update, or I will try push a change. At the moment, looks like the drops for the normal vs wilderness monsters will be wrong. So I will leave the issue open.