🚀 Add bank account transaction integration

oss-apps / split-pro

Open source alternative to Splitwise

https://splitpro.app

MIT License

368 stars 36 forks source link

🚀 Add bank account transaction integration #132

Open alexanderwassbjer opened 3 weeks ago

alexanderwassbjer commented 3 weeks ago

Implemented an integration that uses GoCardless api to fetch bank account transactions. Then when you want to add an expense you can either fill it manually or you can pick from your transactions and it will automatically be added as an expense. There is also a function to "multi add" multiple transactions at the same time. If a transaction already has been added to a group you cant add it once again. GoCardless page

Other changes:

Fixed dark/light mode.
Fixed "total expenses" which didn't excluded deleted expenses.
Added a clear field button to add expense page.
Changed to on addExpense function redirect link.
Added the new feature to start page.
Added information about the new feature to readme.

Screenshots:

alexanderwassbjer commented 3 weeks ago

@KMKoushik :)

alexanderwassbjer commented 3 weeks ago

I have also added i18n support for this feature in another PR that is based on this PR: https://github.com/oss-apps/split-pro/pull/89. If this gets merged I can open a PR with i18n support for this aswell.

https://github.com/alexanderwassbjer/split-pro/tree/feature/i18n-support

KMKoushik commented 3 weeks ago

@alexanderwassbjer changed the base to v2!

alexanderwassbjer commented 3 weeks ago

this looks good overall with some comments. please lemme know what you think!

tysm for this PR really appreciate it. this is really awesome!

think it's best to merge in v2, test thoroughly and release it with other features! (i'll create a new branch)

Awesome! Iam happy you liked it. I will go over it again, check your comments and fix some other stuff.

It would be nice if it was released in v2!

KMKoushik commented 3 weeks ago

Awesome! Iam happy you liked it. I will go over it again, check your comments and fix some other stuff.

It would be nice if it was released in v2!

ofcourse this is going to be star feature!

alexanderwassbjer commented 3 weeks ago

@alexanderwassbjer Some other improvement ideas:

Encrypt the cache for the transactions.
Add multiple bank accounts for different providers.

KMKoushik commented 3 weeks ago

i'll have to think about this over the weekend!