search

oss-apps / split-pro

Open source alternative to Splitwise
https://splitpro.app
MIT License
373 stars 36 forks source link

Use ShadcnUI's OTP input element for our auth flow #33

Closed KMKoushik closed 8 months ago

KMKoushik commented 8 months ago

https://ui.shadcn.com/docs/components/input-otp

anantraghuvanshi commented 8 months ago

Since we receive 5 characters in the OTP, I think the option we could go for be :

image

or

image

I would like to hear you on this @KMKoushik

KMKoushik commented 8 months ago

Since we receive 5 characters in the OTP, I think the option we could go for be :

I would like to hear you on this @KMKoushik

That sounds good!

anantraghuvanshi commented 8 months ago

Since, we are modifying this page, what I was thinking should be updated is the text " We have sent an email with the OTP. Please check your inbox" where the plain email could be something like testXXXX@XXXil.com. Would that be okay @KMKoushik ?

KMKoushik commented 8 months ago

Since, we are modifying this page, what I was thinking should be updated is the text " We have sent an email with the OTP. Please check your inbox" where the plain email could be something like testXXXX@XXXil.com. Would that be okay @KMKoushik ?

I also don't mind putting the entire email!

anantraghuvanshi commented 8 months ago

38 fixes this. Kindly review @KMKoushik