search

oss-apps / split-pro

Open source alternative to Splitwise
https://splitpro.app
GNU Affero General Public License v3.0
127 stars 10 forks source link

Splitwise import doesn't seem to properly handle groups/transactions #46

Open dfego opened 2 months ago

dfego commented 2 months ago

I've just successfully imported my data from Splitwise. I notice that it recognizes and creates my groups, but those groups don't have any transactions associated with them, and they all show as settled up. Actually, while my overall balance looks correct, I don't see any of my transactions anywhere. I will note all of my transactions are in groups.

KMKoushik commented 2 months ago

@dfego This is intended behaviour for now. Just don't want to polute DB with 1000s of transactions, So imported only what's absolutely necessary ie) Outstanding balance and group with users. Do you think importing txs also very important?

KMKoushik commented 2 months ago

May be I'll have explain it in the import page, so others won't get confused!

dfego commented 2 months ago

@KMKoushik for me, yes, it's essential. I only really use this with one other person, but the transaction history is important for review in determining what has been dealt with (specifically), and what hasn't, and which bucket thing is in (running ledger vs. major expenses). My use case may or may not be common though, I'm not sure.

Perhaps making it opt-in would be helpful? For my own data, I already could see all my people and the total balance, so importing that would be as trivial as me having made a single "from splitwise" transaction of the full amount. The import didn't do much for me there.

KMKoushik commented 2 months ago

@dfego Gotcha, I'll keep this as an enhancement and will try to work on it. I'll have to make sure I don't kill my DB accidentally lol.

Would you be okay if it imports upto recent 1000 expenses max? The number is arbitary, i'll come up with exact number soon!

dfego commented 2 months ago

1000 would work for me, I've got 900+ myself. If there were some lower limit I could probably go in and coalesce things a bit, but starting with no history is a little rough! What database is this using? Are your concerns disk space or performance?

KMKoushik commented 2 months ago

@dfego It's postgres, Not woried about space or perf of DB. Say some one have 10K txes and while processing App server may go down cuz of memory. May be I'm overthinking it and it's fine. either I have to do some stress test to be sure