oss-aspen / 8Knot

Dash app in development to serve open source community visualizations using GitHub data from Augur. Hosted app: https://eightknot.osci.io
MIT License
51 stars 60 forks source link

Add welcome page, pt. 1 #354

Closed JamesKunstle closed 1 year ago

JamesKunstle commented 1 year ago

Terrible looking welcome page with the few categories filled in.

I'm going to check out some other sites to get some inspiration on how to make the page look less terrible.

Probably need to not use cards in this context and just markup the page like a normal HTML document.

cdolfi commented 1 year ago

@JamesKunstle lmk when/if this is ready for review (wasnt sure with it being a draft)

JamesKunstle commented 1 year ago

@cdolfi Ah no, I'm almost finished with a non-crap welcome page right now. Just getting some screenshots to work.

I'm doing two Welcome sections to be 70% done with the page, then we can decide what else should be there in the future.

cdolfi commented 1 year ago

@JamesKunstle Sweet sounds good just lmk

JamesKunstle commented 1 year ago

@cdolfi PRing this page w/o the next part that I think we should do - the instructions on how to log in and use groups - because that would make the PR too big, I think. Should merge this, and then add another part of the page later.

cdolfi commented 1 year ago

@JamesKunstle That makes sense to me, can you create an issue for that?

JamesKunstle commented 1 year ago

@cdolfi yeah the issue is: #353 I think.

JamesKunstle commented 1 year ago

@cdolfi responded to review

JamesKunstle commented 1 year ago

A few small comments but look good to me. Any reason to not have the welcome page as the first opened and removing the home now? I am personally all for it

Yeah I think that's fine- I'll update the branch, de-register the Home page, and move the Welcome page to index-location.