Contributor pull request review assignment

cdolfi commented 1 year ago

Things to note during review:

We should consider before turning this query into a materialized view if we want to join on the contributors table to have the login info available off the bat for viewing on a local/private instance
the conversation on pages will definitely move the location of the graph. This location is temporary until we have a good home for it. I have a few visualizations that are close to done and once those are in lets discuss new page break downs
Ctrb_id on the hover is on the side. Currently thats the only way I can see how to do it with the cntb_id not being static (spent multiple hours yesterday trying to figure it out)

JamesKunstle commented 1 year ago

@cdolfi My comments on #442 apply here nearly directly- same rationale, pretty willing to just merge this after we've solidified the Info section and the interface.

JamesKunstle commented 12 months ago

@cdolfi same comments now as for #442

cdolfi commented 12 months ago

@JamesKunstle ready for review based on comments

JamesKunstle commented 12 months ago

@cdolfi responded to both in #442, very nearly at consensus

JamesKunstle commented 12 months ago

@cdolfi approved, pls manually merge to handle conflicts.

oss-aspen / 8Knot

Contributor pull request review assignment #444