oss-aspen / 8Knot

Dash app in development to serve open source community visualizations using GitHub data from Augur. Hosted app: https://eightknot.osci.io
MIT License
47 stars 59 forks source link

Add issues closed line graph and update hovertemplate #479

Closed christinaexyou closed 11 months ago

christinaexyou commented 11 months ago

@cdolfi Resolves part of https://github.com/oss-aspen/8Knot/issues/468 and https://github.com/oss-aspen/8Knot/issues/470 by making the following changes:

christinaexyou commented 11 months ago

@cdolfi Changes made:

cdolfi commented 11 months ago

@christinaexyou let me know when this is ready for re-review. If there is not an obvious way of fixing file wide this @JamesKunstle might have some guidance

JamesKunstle commented 11 months ago

@cdolfi @christinaexyou I'll pull this now and take a look to see if I have any ideas.

JamesKunstle commented 11 months ago

Working on this, though I'm getting a DBReadFailure for some reason, so I may need to spend some time debugging tomorrow before I can actually review this PR.

JamesKunstle commented 11 months ago

@christinaexyou

Review

I pulled your most updated branch and tried the following orgs/repos, but neither 'Issues Closed' nor 'Issue Messages' lines appeared.

'chaoss' org '3scale' org 'kubernetes/kubernetes' repo

This is a screenshot of what I get for 'kubernetes/kubernetes':

Screenshot 2023-10-04 at 1 58 47 PM

And this is my current branch's log:

Screenshot 2023-10-04 at 2 01 02 PM

Which I believe is up to date.

One additional request

I'd love it if the Action Type was in the hover information. That'd make reading the graph much easier.

christinaexyou commented 11 months ago

@cdolfi @JamesKunstle Changes made:

JamesKunstle commented 11 months ago

@christinaexyou Yuh this looks great, gonna merge it.