search

oss-aspen / 8Knot

Dash app in development to serve open source community visualizations using GitHub data from Augur. Hosted app: https://eightknot.osci.io
MIT License
47 stars 59 forks source link

fix issue_assignee_query and pr_assignee_query #488

Closed JamesKunstle closed 11 months ago

cdolfi commented 11 months ago

@JamesKunstle is this still relevent / necessary?

JamesKunstle commented 11 months ago

Yes, opened as fix

cdolfi commented 11 months ago

https://github.com/oss-aspen/8Knot/issues/487 confused bc of the closing and comment of this

JamesKunstle commented 11 months ago

https://github.com/oss-aspen/8Knot/issues/487 confused bc of the closing and comment of this

487 addresses the problem but misidentifies the cause as being from the materialized view.

This PR just fixes up the application query to be correct SQL, keeping the materialized view as-is.

JamesKunstle commented 11 months ago

still a little confused as to why this doesnt work on your branch in current state as it does on mine (even after rebuild) but they are equivalent so lgtm

Did you delete the existing Redis container?

docker compose down; docker compose up --build

The query wasn't fully correct SQL so it shouldn't work anywhere- it doesn't work in dbeaver. I'm guessing the cache container was still warm despite rebuild, which would happen if you didn't down the compose.

cdolfi commented 11 months ago

sounds good im good to merge