Closed cdolfi closed 11 months ago
@cdolfi I pulled this branch and looked at it on my laptop and also looked at it in greyscale. This seems like an improvement over our existing color set, and I like how it looks as well.
I'd like to adopt this palette and see what others think for some feedback. I can imagine that it'll be a polarizing palette to pick for some people, but I think it looks good and serves the purpose that we want it to.
@cdolfi just run pre-commit and then we'll be good to merge.
@JamesKunstle Sounds good! The things it is failing on on pre-commit are not showing up for me locally. Any suggestions on what to do?
@cdolfi That's a good question. I think that that's because some of the issues are in Christina's most recent PR.
I pulled your branch and was able to format the remaining file with pre-commit run --all-files
If that doesn't works, running black
on the contrib_importance_over_time
file should be sufficient.
@JamesKunstle Reran pre commit again and did not work. How do you run black on the file? Was doing some googling and did not find anyting
It's a command line tool, so:
black 8Knot/pages/contributors/visualizations/*
will run it on every file in that subdirectory.
@JamesKunstle got it to work, once it gets your review itll be good to merge
@cdolfi does this PR include color updates for everything?
"Pull Request Activity- Staleness" and "Issue Activity- Staleness" have the original palette applied.
Unclear if this is the intended behavior
@JamesKunstle yes, 3 out of the 6 colors are the same from the last one
@cdolfi Oh okay nice, sounds good!
First round pass at a color redesign. Let me know what you think. Once we come to a consensus on the new colors ill go through and update all the visualizations for the most optimal color combo of the set