search

oss-aspen / 8Knot

Dash app in development to serve open source community visualizations using GitHub data from Augur. Hosted app: https://eightknot.osci.io
MIT License
47 stars 59 forks source link

search bar background color update #501

Closed cdolfi closed 11 months ago

cdolfi commented 11 months ago

this pr updates the background of the search bar. lmk what you think

JamesKunstle commented 11 months ago

I think the search bar styling just needs a net refactor. If the background is black, the rest sticks out and kinda looks "partially rendered" I guess.

On a razors edge, I think I prefer the search bar background to be white along with the other stuff in the bar rather than having a black background with white outline and white button.

The search bar definitely sticks out as the remainder default-styled thing on the page though, but idk what the right styling is ultimately.

cdolfi commented 11 months ago

@JamesKunstle Personally I agree on the repo search bar looks better in the prior format, but the visualization ones I think are improved by this change. Lmk what you think of those search bars specifically and we could just apply this change on those

JamesKunstle commented 11 months ago

@cdolfi Yeah for the bot filters I'm on the same page. They look better with this styling change. I'd be down to make one overall styling change this time and create a subsequent issue to reimagine the search bar styling later.

cdolfi commented 11 months ago

@JamesKunstle Sounds good I updated the pr to just apply to the visualizations