Closed cdolfi closed 9 months ago
Note: we need to look over the overall styling changes before merging this. Check out the hosted instance next to this one to see the difference @JamesKunstle
@JamesKunstle Ready for re-review. _bot.py is not in its final form as this solution causes that query to be called for every visualization and each time its rerun. Let me know how you think it should be changed to handle that
@JamesKunstle Ready for re-review. _bot.py is not in its final form as this solution causes that query to be called for every visualization and each time its rerun. Let me know how you think it should be changed to handle that
@cdolfi commented above
Note: we need to look over the overall styling changes before merging this. Check out the hosted instance next to this one to see the difference @JamesKunstle
I see the differences. I don't really mind them honestly. I'd like to merge this and then create a follow-up issue to fix styling rather than dragging this PR through that fix.
@JamesKunstle Sounds good, the zoom in bothers me a lot more than the darkened tabs but not a huge fan of either. Ill open an issue for that. Once the heatmap is merged ill rebase on that. Besides that this pr is good to go for me. Let me know if you still have issues with the query and we can figure it out. Not sure whats happening as its working for me
@JamesKunstle Sounds good, the zoom in bothers me a lot more than the darkened tabs but not a huge fan of either. Ill open an issue for that. Once the heatmap is merged ill rebase on that. Besides that this pr is good to go for me. Let me know if you still have issues with the query and we can figure it out. Not sure whats happening as its working for me
I actually don't have a zoom-in render on my end. I wonder if it's a screen-size thing?
@cdolfi once the conflict is fixed I'll merge!
oh also make sure to squash your commits
@JamesKunstle Ready to go! (cant squash any further without messing up relevant history)
@cdolfi there's a rebase conflict in color.css- if you fix that you can just force-push this branch into dev. If you want me to do it that's okay too
@JamesKunstle on my side that conflict is fixed. Let me know if its still showing for you
lol github what are you doing
@cdolfi go ahead and merge it yourself, idk why the github UI is giving me a hard time
This PR implements bot filtering. Decisions still need to be made around the styling of the filter switch itself and the overall app changes from the dash bootstrap components update
https://community.plotly.com/t/dbc-nav-styling-change-with-update/80094/7