Closed cdolfi closed 8 months ago
@JamesKunstle Squashed into 2 commits, personally I do like having multiple commits (2 in this case) where each are specific to different steps in the dev process
@JamesKunstle Squashed into 2 commits, personally I do like having multiple commits (2 in this case) where each are specific to different steps in the dev process
I'm not ultra picky about our commit history- I generally prefer PR:commit to be 1:1 and to not separate PR revisions from the net feature added, but I'm amenable to your process if you want it that way.
@JamesKunstle yeah I just like having major check points if there are major changes/time periods btw the original pr and the final changes. Ive hit a few points where having that history has been really helpful to go back for various reasons
@JamesKunstle yeah I just like having major check points if there are major changes/time periods btw the original pr and the final changes. Ive hit a few points where having that history has been really helpful to go back for various reasons
Yeah if that works for you I'm totally good w/ it
oh also squash plz commits