search

oss-aspen / 8Knot

Dash app in development to serve open source community visualizations using GitHub data from Augur. Hosted app: https://eightknot.osci.io
MIT License
47 stars 58 forks source link

Lottery Factor Line Graph: Pattern and date range removal #688

Closed cdolfi closed 2 months ago

cdolfi commented 3 months ago

This graph did/does not have the same bug that the pie chart had. During this audit it was discovered that the date range functionality was broken. After viewing this graph with a project with a 10+ year history, I found this feature unnecessary. In this pr I removed the date picker for reasons above and the pattern selector as that is prior implementation of github bots. Old viz for reference: Screenshot 2024-04-05 at 1 30 55 PM

JamesKunstle commented 2 months ago

What specifically are you removing here? I pulled your branch and it still has the date-picker but not the threshold range-slider or the bot pattern matcher.

cdolfi commented 2 months ago

@JamesKunstle let me go check when I get back to my computer. It should be removing the date range picker and patterns so something might have gotten messed up when I pushed. Threshold 100% should be there so something definitely isn't right on my end

cdolfi commented 2 months ago

@JamesKunstle This is what I see when I run it locally. Let me know if you are seeing something different

Screenshot 2024-04-09 at 4 56 18 PM
JamesKunstle commented 2 months ago

@cdolfi Yeah that's not what I'm seeing- lemme make sure that I fully rebuild and everything

JamesKunstle commented 2 months ago

@cdolfi I confirmed that I'm starting 8Knot with the commit that's top of this branch, could you confirm that you've pushed all of your changes?

Screenshot 2024-04-10 at 12 06 27 PM

cdolfi commented 2 months ago

@JamesKunstle This PR is for the Lottery Factor line graph not the project velocity visualization

JamesKunstle commented 2 months ago

@cdolfi My bad, I swapped the two in my head and was looking at the date picker / value adjustment boxes. I confirmed that the lottery factor viz renders and behaves as expected on my end.