search

oss-aspen / Rappel

Apache License 2.0
10 stars 23 forks source link

Updated Requirements.txt and Include More Dynamic Versions of Notebooks #214

Closed sgoggins closed 1 year ago

sgoggins commented 1 year ago

There were files missing from requirements.txt, including networkx and jupyter-lab.

There were also a few logic errors in the database connection in one notebook. Probably just from an older version.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

oindrillac commented on 2023-06-14T04:36:58Z ----------------------------------------------------------------

Any idea why we are getting no cntrb_ids here?


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

oindrillac commented on 2023-06-14T04:36:59Z ----------------------------------------------------------------

Cool plot! Can you provide some context in markdown on what exactly are we trying to achieve here?

Any particular reason we are removing the coloring legends here?


sgoggins commented on 2023-07-07T19:11:18Z ----------------------------------------------------------------

I removed this plot. I think its less useful than I hoped.

In its place I created a dependency notebook that focuses on dependencies as a separate matter.

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

oindrillac commented on 2023-06-14T04:37:00Z ----------------------------------------------------------------

Line #3.    #blue_patch = mpatches.Patch(color='blue', label='Repository')

Can we keep the coloring legends here?


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

oindrillac commented on 2023-06-14T04:37:01Z ----------------------------------------------------------------

This dataframe does not seem to be populating as the cntrb_ids in the issue dataframe seems to be all None


sgoggins commented on 2023-07-07T19:10:37Z ----------------------------------------------------------------

@oindrillac: I fixed this in the latest push.

sgoggins commented 1 year ago

View / edit / reply to this conversation on ReviewNB

oindrillac commented on 2023-06-14T04:36:58Z ----------------------------------------------------------------

Any idea why we are getting no cntrb_ids here?

I fixed the issues query. In the issues table the cntrb_id column is intended to indicate who closed the issue, however this data is not readily available for all repos in the GitHub API.

The reporter_id contains a cntrb_id for the person who opened the issue, and that is now included in the query and it produces results.

sgoggins commented 1 year ago

@oindrillac: I fixed this in the latest push.

View entire conversation on ReviewNB

sgoggins commented 1 year ago

I removed this plot. I think its less useful than I hoped.

In its place I created a dependency notebook that focuses on dependencies as a separate matter.

View entire conversation on ReviewNB

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.