Back End: 'Code Review Ratio' metric data is abnormal in the 'apache pulsar' repository

oss-compass / compass-metrics-model

GNU Affero General Public License v3.0

13 stars 4 forks source link

Back End: 'Code Review Ratio' metric data is abnormal in the 'apache pulsar' repository #49

Open lishengbao opened 1 year ago

lishengbao commented 1 year ago

By Asaf Mesika description. Something doesn’t make sense in this panel , I know for a fact that this project forces PR reviews. How can it be the percentage is so harsh - 50%

By looking at Compass's algorithm, for example: https://github.com/apache/pulsar/pull/13586 , this pr has no review comment, so it is not counted, but this pr has been reviewed and approved by @tuteng. Compass will fix this situation later

lishengbao commented 1 year ago

Add a code_review_approved_ratio(approved PRs have 0 comments) as a reference metric.

eyehwan commented 11 months ago

@lishengbao I remember this issue has been solved, right?