oss-generic / process

The OSS-Generic Reference Process

https://oss-generic.github.io/process/

MIT License

6 stars 19 forks source link

PR life cycle: no need to duplicate reviewers as assignees #36 #62

Closed damithc closed 7 years ago

damithc commented 7 years ago

Fixes #36

PR lifecycle requires reviewers to be assigned as 'assignees' of
the PR. This is because GitHub did not have a way to filter PRs by
review requests.

GitHub has added the ability to filter PRs by review requests
https://github.com/blog/2306-filter-pull-request-reviews-and-review-requests

Let's remove the requirement to use the assignees field in PRs to
indicate reviewers.

CanIHasReview-bot commented 7 years ago

v1

@damithc submitted v1 for review.

[v1 1/1] PR life cycle: remove use of assignees field in PRs

(:books: Archive)

Checkout this PR version locally

```shell git fetch https://github.com/oss-generic/process.git refs/pr/62/1/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you want to fetch this PR to.

CanIHasReview-bot commented 7 years ago

v2

@damithc submitted v2 for review.

[v2 1/1] PR life cycle: remove use of assignees field in PRs

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2)

Checkout this PR version locally

```shell git fetch https://github.com/oss-generic/process.git refs/pr/62/2/head:BRANCHNAME ``` where `BRANCHNAME` is the name of the local branch you want to fetch this PR to.