search

oss-review-toolkit / ort

A suite of tools to automate software compliance checks.
https://oss-review-toolkit.org
Apache License 2.0
1.56k stars 306 forks source link

Drop support for several old versions of ScanCode #8881

Open fviernau opened 1 month ago

fviernau commented 1 month ago

ScanCode 30.0.0 1 invented an output format version. Starting with that version, it became possible not have ScanCode version specific parsing logic anymore, but to only have the parsing specific to the output format version. The first handling of that output format version in ORT has been introduced 2 for ScanCode version 30.1.0.

Drop support for all ScanCode versions prior to 30.1.0 from ORT, to simplify the code.

sschuberth commented 1 month ago

Drop support for all ScanCode versions prior to 30.1.0 from ORT, to simplify the code.

More generally, we should say "drop support for all ScanCode versions that do not write the outputFormatVersion field".

fviernau commented 1 month ago

More generally, we should say "drop support for all ScanCode versions that do not write the outputFormatVersion field".

I phrase it like this, because we skipped integrating ScanCode versions 30.0.0 and went to 30.1.0 directly. So, I wanted to save the effort to investigate that old 30.0.0 support.

sschuberth commented 1 month ago

So, I wanted to save the effort to investigate that old 30.0.0 support.

I believe we can skip it anyway, as like we discussed, with general outputFormatVersion support the ScanCode version does not matter anymore, so we also don't need to prove that supporting outputFormatVersion 1.0.0 indeed works for parsing ScanCode 30.0.0 results.