oss-slu / Mouser

GNU General Public License v3.0
1 stars 7 forks source link

Fixes Unequal Group Sizes #108 #122

Closed rc10283 closed 1 year ago

rc10283 commented 1 year ago

Fixes #108.

kate-holdener commented 1 year ago

How did you test this fix?

loganwyas commented 1 year ago

@rc10283 Please describe the changes that were made to the code and how these changes relate to the linked issue.

rc10283 commented 1 year ago

Group sizes were allowed to be unequal, the example given is 12 animals 2 groups with 5 animals per cage that would have the final 2 animals stripped from the experiment. Using a conditional, I wrote that if the total number of animals, is greater than the animals per cage * the number of cages than a unequal group size warning would appear an the investigator would be asked to reenter the info. Earlier, I did not see a merge conflict that had two warning labels listed as 3, i instead changed my warning of unequal group sizes to label 4. If you have any concerns or anything else the issue should fix please let me know.

loganwyas commented 1 year ago

@rc10283 With the example given, I receive a blank warning message:

image

rc10283 commented 1 year ago
Screen Shot 2023-10-10 at 12 53 51 PM