jackbelyeu
commented
2 weeks ago Closing since PR #242 is a repost of these changes
Closed NNewbauer closed 2 weeks ago
jackbelyeu
commented
2 weeks ago Closing since PR #242 is a repost of these changes
Fixes #240
What was changed?
Method of collecting data from serial port was changed from listening to two separate inputs to threading.
Here, describe what part of the application you changed (e.g. login page, database, etc.). If possible, mention what specific components were added, removed, or modified.
Changed data_collection.py, added serial_listener.py and listenTest.py. Data collection calls for serial listener components that handle threading.
Why was it changed?
Listening for two different inputs proved to be incredibly buggy and inefficient, so doing threading appeared to be the only fix.
Here, describe the issue that you are fixing with this code, and why your code fixes it.
Data inputs popped up an input box prematurely that immediately shut down, this bug created extra unneeded button clicks and general bugs that we do not want. Fixing this is essential to a smooth user experience.
How was it changed?
Added a new class, SerialReader and SerialDataHandler to control threading from serial inputs, these classes are in charge of reading the data and pulling what is specifically needed for the input, the old method couldn't handle that.