oss-slu / Pi4Micronaut

A java library combining Micronaut and Pi4j to streamline hardware connectivity to Raspberry Pi's
https://oss-slu.github.io/Pi4Micronaut/
Apache License 2.0
8 stars 7 forks source link

Fixes #246 #250

Closed ghost closed 2 months ago

ghost commented 2 months ago

Fixes #246 Created error handling blocks for each controller that uses LED status indication. This was changed because for the issue to be resolved the controllers that use LED status indication needed to have informational error handling. Try catch blocks were added to areas of where the controllers used LED status indication in the form of LEDHelper(ledon, ledoff). Informational error messages were added for ease of error handling as well as logging capability.

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: tmacas
:x: Thomas Macas


Thomas Macas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

yrlmanoharreddy commented 2 months ago

The fix effectively handles the error management with LED status indication and meets the feature requirements. However, there are some minor issues, including extra whitespace and duplicate imports, that need to be addressed for better code quality. Additionally, refining the logging for clarity would be helpful. Please make these changes and push the updated code. Great work so far—looking forward to the revisions!

ghost commented 2 months ago

Fixes #246 Completed round of solutions to comments from code review. Removed unnecessary white spaces and import repeats for code clarity and quality.

yrlmanoharreddy commented 2 months ago

Closing the existing pull request and opening a new pull request to address the unresolved CLA issue. This will give the CLA assistant a fresh start to track the commit properly.

New pull request url: https://github.com/oss-slu/Pi4Micronaut/pull/254