oss-slu / bubble_scan

GNU General Public License v3.0
0 stars 7 forks source link

The algorithm is able to extract the ROIs of the custom sheets #107

Closed ramezmosad closed 3 weeks ago

ramezmosad commented 1 month ago

Fixes #104

What was changed?

Why was it changed? This change addresses the need to properly extract ROIs for each page of custom answer sheets in a structure similar to that used for Scantron sheets.

How was it changed?

  1. New SheetProcessor Abstract Class:
  1. New CustomProcessor Class:
  1. New Folder Structure for Custom Sheets:
    • Added customAligned and customROIs folders to data/ to separate custom sheet data from Scantron data. This keeps custom sheet processing independent, organized, and easy to manage.

Screenshots that show the changes (if applicable):

Screenshot 2024-10-27 at 3 08 54 AM Screenshot 2024-10-27 at 3 09 03 AM Screenshot 2024-10-27 at 3 09 13 AM Screenshot 2024-10-27 at 3 09 21 AM Screenshot 2024-10-27 at 3 09 44 AM
ramezmosad commented 3 weeks ago

@Chirag2x Yes, I feel like it would be easier to have two separate files for handling the two different sheet types. And yeah different functions would be called based one whichever sheet type the user chooses. Do you think having it all in one file would be easier? I was just unsure about how I would go about that. There's the option of just implementing the methods that are in Custom.py inside Scantron.py. For example, inside Scantron.py I would add an "extractCustomROIs" method and that would just be the "extractROIs" method that's defined in Custom.py. I'm not sure which way makes more sense so if you have any recommendations please let me know!

Chirag2x commented 3 weeks ago

Well, Both of them are right approach. Let go ahead with the method you pushed. I am approving the merge.