search

oss-slu / esp

MIT License
0 stars 1 forks source link

prototype_view: sprint 1 commit #26

Closed haydenkarl22 closed 7 months ago

haydenkarl22 commented 7 months ago

Sprint 1 Progress: Hayden Karl

The issue I'm working on currently requires me to design some prototypes of the view of the user for this application. Our group met with Dr. McCulla, a professor in the Chemistry department to get his feel for the look and some desired functionality of these prototypes. Saved in this dir is a screenshot of the current view of the ORCA file converter.

Dr. McCulla didn't suggest any styling for the page, however he did inform me that the current elements already on the view, such as the file selector button, the section selection dropdown tab, and the file name text box are all features he wants to stay the same, with maybe slight optimizations for the backend as needed. He also wanted the ability to enter in keywords that the application would search for and use the data that is under the keywords, so another textbox that takes keywords will be necessary. This, however, is all he suggested, so I'll design a couple of simple pages with these suggestions in mind while also adding some stylings of my own. My stylings won't detract from the functionality or use of the page. My goal is to make this page look more like something a company or school would deploy for public use rather than a barebones page.

The directory for the prototypes is made as stated in the root directory.

kate-holdener commented 7 months ago

Sprint 1 Progress: Hayden Karl

The issue I'm working on currently requires me to design some prototypes of the view of the user for this application. Our group met with Dr. McCulla, a professor in the Chemistry department to get his feel for the look and some desired functionality of these prototypes. Saved in this dir is a screenshot of the current view of the ORCA file converter.

Dr. McCulla didn't suggest any styling for the page, however he did inform me that the current elements already on the view, such as the file selector button, the section selection dropdown tab, and the file name text box are all features he wants to stay the same, with maybe slight optimizations for the backend as needed. He also wanted the ability to enter in keywords that the application would search for and use the data that is under the keywords, so another textbox that takes keywords will be necessary. This, however, is all he suggested, so I'll design a couple of simple pages with these suggestions in mind while also adding some stylings of my own. My stylings won't detract from the functionality or use of the page. My goal is to make this page look more like something a company or school would deploy for public use rather than a barebones page.

The directory for the prototypes is made as stated in the root directory.

@haydenkarl22 You should add the features that the client wants to the prototype (ability to enter in keywords, example of data that matched the keywords). I wouldn't worry about styling for now.

haydenkarl22 commented 7 months ago

Added one prototype of the home page under prototypes, along with screenshots of what's changed (those files are labeled as prototypes, the other screenshot is the current view). I sent my screenshots to Prof. McCulla for his approval, so I'm currently waiting for his input.

rkarmuri commented 7 months ago

I see the prototypes directory exists at the root of the repo. I would need instructions to run your code in the Read Me file of your branch. I cannot merge it without testing it. Also, copy the whole team when you are emailing the client to make sure we all are on the same page. Let us know if the client responds, or we can meet with them at their convenience.

haydenkarl22 commented 7 months ago

Hey, I took your advice and added a readme file that explains how to launch localhost with the prototype view, Let me know if there are any more comments or concerns. Also, since I haven't had a response from Mr. McCulla, I'll send another email to him and his student assistant, and I'll cc you in the email. Thanks for the heads up.

rkarmuri commented 7 months ago

@haydenkarl22 Based on your instructions, I removed the files in the views folder and added your current code to it, and it works fine. However, there is a small syntax error in your HTML div tag in the 1st line of your code. I will merge the PR as it looks good to me. Moving further, could you make the Read Me file more readable and instructive with commands to be issued and output expected? Also, you'll be able to change the current code in the front-end views folder to your latest code, which I will add as a separate issue. The reason is the command: ng serve picks from the front-end folder where we have the JSON file. Overall, great effort, and I appreciate your work.