oss-slu / esp

MIT License
0 stars 1 forks source link

Issue48: fix test cases #50

Closed haydenkarl22 closed 4 months ago

haydenkarl22 commented 4 months ago

Fixes issue #46 I started by fixing the imports in test.py, the test file couldn't import app.py because of our project structure: app is contained in the create_app() function, preventing it from being directly accessed. To fix this, I defined an app_instance object that is defined a a create_app() function call. This allows the app object (formatted in app_instance) to be called by test.py. Next, I defined an absolute path for the file_path variable in the test_valid_request field as originally, this was a hardcoded path. Now, the path is universal, so this test works on all machines.

SiriChandanaGarimella commented 4 months ago

@haydenkarl22 - I added the requirements.txt file to resolve the import issues and updated the workflow for the test cases to run. Please review it once and let me know if you are good with these changes.

haydenkarl22 commented 4 months ago

These changes look good to me.