search

oss-slu / esp

MIT License
0 stars 1 forks source link

Fixes Issue#51 #55

Closed mkalal6 closed 4 months ago

mkalal6 commented 4 months ago

Created a comment in the file that needs to be changed throughout this sprint in order to fix Issue 51.

mkalal6 commented 4 months ago

This issue is completed. Changes Made:

SiriChandanaGarimella commented 4 months ago

@mkalal6 - It looks good but a few changes are needed. Could you please check on the below?

  1. Submit Search Query position should be fixed. It is changing now on selecting the "Is the search criteria same for all search terms" checkbox.
  2. The card must be created after clicking the Submit Search Query button.
  3. The download option should be enabled once the data is entered in all the mandatory fields.
  4. Change the name from 'Temp' to 'Draft Same Search ORCA page' and remove the URL from the Navbar. This adjustment is for development purposes and doesn't need to be visible to everyone.
SiriChandanaGarimella commented 4 months ago

@mkalal6 - I've implemented a few validations for the 'Submit Search Query 'button. Now, it's only enabled once values are provided in all fields, and I've removed the API call. Also, I've updated the NavBar and changed the filename. Please review these changes and let me know if there are any issues.