search

oss-slu / esp

MIT License
0 stars 1 forks source link

issue54: Preview the Output Data in Tabular Format #58

Closed haydenkarl22 closed 4 months ago

haydenkarl22 commented 4 months ago

I've currently just added a simple "Preview File" button that has no current action when clicked.

SiriChandanaGarimella commented 4 months ago

@haydenkarl22 - Could you please elaborate on the changes made in this PR? When I click on 'Preview File', I get the following error:

image

Also, could you update the following:

  1. Change the button name from 'Preview File' to 'Preview Output'.
  2. Add space between the 'Download Output' and 'Preview Output' buttons.
  3. Place the 'Preview Output' button to the left of the 'Download Output' button.
haydenkarl22 commented 4 months ago

I'm not sure why you're getting these errors, I'm thinking maybe when I pushed it, I didn't push all the files I edited. I made the changes you asked for regarding the 'Preview Output' button, so I'll try re pushing everything and hopefully, things work on your end. I'll post a screenshot of me entering the same file and search queries you used in your screenshot and the code working on my end.

image

SiriChandanaGarimella commented 4 months ago

@haydenkarl22 - It works fine now. Great work! Could you create a function for all the repeated code in the preview API and find-sections API as it would help in code reusability?