search

oss-slu / shelter_volunteers

MIT License
3 stars 4 forks source link

Invalid DOM property issue #63 fixed #66

Closed vakhil-98 closed 8 months ago

vakhil-98 commented 9 months ago

Fixes #63

What was changed?

Updated JSX attributes from 'class' to 'className' in the VolunteerDashboard, Shelters, Shifts, IndividualShelter components.

Why was it changed?

Resolved a React warning regarding the use of the deprecated class attribute, change ensured adherence to React conventions.

How was it changed?

Updated 'class' to 'className' for the relevant JSX elements in multiple locations in VolunteerDashboard, Shelters, Shifts, IndividualShelter components

Screenshots that show the changes (if applicable): image

SiriChandanaGarimella commented 9 months ago

@vakhil-98 Good effort in getting rid of the warning. However, I see that the fix needs to be implemented in a few more pages (shiftlist.js and shelters.js). Could you please fix these so that we can merge the PR?

https://github.com/oss-slu/shelter_volunteers/pull/66/files#diff-9541b736269b961c9d3ae9c4c839eddc4db95d3aa3212176f523e976276b87b5R180

https://github.com/oss-slu/shelter_volunteers/blob/main/client_app/src/Components/ShiftList.js#L60

vakhil-98 commented 9 months ago

@vakhil-98 Good effort in getting rid of the warning. However, I see that the fix needs to be implemented in a few more pages (shiftlist.js and shelters.js). Could you please fix these so that we can merge the PR?

https://github.com/oss-slu/shelter_volunteers/pull/66/files#diff-9541b736269b961c9d3ae9c4c839eddc4db95d3aa3212176f523e976276b87b5R180

https://github.com/oss-slu/shelter_volunteers/blob/main/client_app/src/Components/ShiftList.js#L60

@SiriChandanaGarimella Thank you for your feedback. I'm glad initial fix was helpful and I've addressed the similar warnings in other pages (ShiftList.js, Shelters.js and ShelterDashboard.js). Could you verify and merge it?