oss-slu / shelter_volunteers

MIT License
3 stars 4 forks source link

Need clear error reporting when signing up for overlapping shifts #88

Closed kate-holdener closed 7 months ago

kate-holdener commented 7 months ago

Describe the bug Using the client side of the application, I can select some shifts that overlap in time (user error) and proceed with the sign up process. The server correctly identifies the problem and only signs me up for one of the shifts, rejecting overlapping shifts and returning an error code 409. However, from the client side, it looks as if the sign-up was successful. See screenshots below.

I select overlapping times:

Screenshot 2024-03-20 at 4 00 30 PM

I submit the request and get this screen, making me think that I signed up for 2 shifts at different shelters:

Screenshot 2024-03-20 at 4 00 59 PM

When I look at my upcoming shifts, I see only one shift (which is correct, because the server only signed me up for one shift):

Screenshot 2024-03-20 at 4 53 25 PM

To Reproduce Steps to reproduce the behavior:

  1. Go to "Sign Up for Shifts"
  2. Sign up for two shifts in different shelters with the same start and end times
  3. Click on Submit Shifts, you'll see the screen that makes you think that you signed up for both shifts
  4. Go to "Upcoming Shifts" and you'll see that you only signed up for one shift

Expected behavior On step 3 above, the confirmation screen should somehow indicate which shifts were successfully created and which were not.