search

oss2019 / pyquotes

API in python to get quotes.
MIT License
3 stars 21 forks source link

Scrapper from quoteload #2

Closed harshraj22 closed 5 years ago

harshraj22 commented 5 years ago

Added the basic version of web scrapper "scrapper.py" . Closes https://github.com/oss2019/pyquotes/issues/3

harshraj22 commented 5 years ago
  1. It is recommended to have one commit for one task. You should squash your commits. And for further changes I suggest you use --amend to make changes in same commit.
  2. Tests are failing because you have not followed PEP8 style. Click on details to see what changes you should make.

1.I don't use terminal for using github. 2.Sure, will be done soon.

akshatkarani commented 5 years ago

1.I don't use terminal for using github.

You should start using it. It will be helpful in the longer run.

akshatkarani commented 5 years ago

@harshraj22 Can you please squash all the commits together. Also refer the issue in commit message to which this PR is related.

harshraj22 commented 5 years ago

@harshraj22 Can you please squash all the commits together. Also refer the issue in commit message to which this PR is related.

How to do so ?

akshatkarani commented 5 years ago

How to do so ?

I am not sure how to do it from the website, I suggest you start using terminal. You can figure out this later, first remove the quote of the day section.

sunn-e commented 5 years ago

@akshatkarani , good to go?

sunn-e commented 5 years ago

I think @harshraj22 , you should send a new PR with requested changes as per @akshatkarani requested. But do not worry, since this is a separate module file, for time being I am approving this. Congrats. Do not forget to claim your swags if you 3 PR are merged, if not, you have time till tomorrow. Hurry.