search

oss2019 / pyquotes

API in python to get quotes.
MIT License
3 stars 21 forks source link

Scrap from quotery #8

Closed DestroyerAlpha closed 5 years ago

DestroyerAlpha commented 5 years ago

7

A scrapper for https://www.quotery.com/ The text files are to match the input with the authors and categories from the website. The text files have been scrapped by me separately.

DestroyerAlpha commented 5 years ago

Made necessary changes.

akshatkarani commented 5 years ago

The text files will increase the size of the package and we cannot do this for every site. There must be some other way. ping @svp19

svp19 commented 5 years ago

Agreed @akshatkarani. I explored the implementation of pyjokes #sourceofinspiration and they too render jokes as text from .py files. Explains why they have only a few.

An alternative would be to set up a server to store all quotes and return them through an API call defined in the package. However, if you do this, then the package won't work offline.

Maybe you could mix both approaches, providing an offline version that is limited and an optional online version that works well.

yugaljain1999 commented 5 years ago

Agreed @akshatkarani. I explored the implementation of pyjokes #sourceofinspiration and they too render jokes as text from .py files. Explains why they have only a few.

An alternative would be to set up a server to store all quotes and return them through an API call defined in the package. However, if you do this, then the package won't work offline.

Maybe you could mix both approaches, providing an offline version that is limited and an optional online version that works well.

We can create offline package with the help of storing all authors and categories in csv file by making own dataset and then can get quotes according to author names and categories through csv file