search

ossama-othman / MaRC

MaRC - Map Reprojections and Conversions
GNU Lesser General Public License v2.1
1 stars 0 forks source link

Performance drop between v0.9.8 and v0.9.9. #40

Closed ossama-othman closed 6 years ago

ossama-othman commented 7 years ago

Performance between v0.9.8 and v0.9.9 dropped by at least 15% in some cases. It's likely that the floating point robustness improvements may be at fault. If that is the case, determine if it is possible to improve performance without sacrificing the improvements.

ossama-othman commented 7 years ago

A running a git bisect session, commit 3781b7895e01d417b06a3df0b92abed83666da01 (Latitude/longitude visibility improvements (#38)) appears to be the cause of the performance drop. Map generation with that commit is noticeably slower than with v0.9.8.

ossama-othman commented 7 years ago

It's not yet clear which of the changes in the patch set are the primary cause of the performance drop. The performance drop may be unavoidable if the improvements in the changes are retained since they appear to be correct.

ossama-othman commented 6 years ago

Commit e30df4e32c9d8c25bbace616cfd7e0ef6018874d improves performance of the virtual image map planes (MU, MU0 and PHASE) substantially, and brings the performance close to what it was in v0.9.8.