search

ossama-othman / MaRC

MaRC - Map Reprojections and Conversions
GNU Lesser General Public License v2.1
1 stars 0 forks source link

Improve OblateSpheroid constructor parameters #48

Closed ossama-othman closed 6 years ago

ossama-othman commented 6 years ago

The MaRC::OblateSpheroid constructor currently accepts three floating point parameters:

where any two of the three are required to be valid (positive). The third will be computed from the two that are supplied. This can be confusing and error prone. Look into altering the constructor so that only two radii/flattening parameters are required.

ossama-othman commented 6 years ago

Introducing specific types (e.g. classes) such MaRC::EquatorialRadius and MaRC::PolarRadius is one way to disambiguate between user supplied parameters. In addition to the rotation parameter, different constructors could accept two such parameters.

ossama-othman commented 6 years ago

The flattening parameter was removed from the OblateSpheroid constructor in PR #71. Closing this issue for now.