The MaRC::ViewingGeometry class (formerly part of MaRC::PhotoImage) expects all supplied longitudes, such as the sub-observation and sub-solar longitudes, to be West longitudes, regardless of the body rotation direction. This is confusing since the typically followed convention is to use West longitudes for bodies with a prograde rotation, and East longitudes for those with retrograde rotation.
Ideally, the supplied longitudes should follow that convention. Doing so would allow for removal of the body rotation checks in MaRC::ViewingGeometry implementation.
Convenience wrappers, such as MaRC::EastLongitude and MaRC::WestLongitude, could be provided to prevent the user from inadvertently supplying an East longitude when a West longitude was expected, or vice versa.
The
MaRC::ViewingGeometryclass (formerly part ofMaRC::PhotoImage) expects all supplied longitudes, such as the sub-observation and sub-solar longitudes, to be West longitudes, regardless of the body rotation direction. This is confusing since the typically followed convention is to use West longitudes for bodies with a prograde rotation, and East longitudes for those with retrograde rotation. Ideally, the supplied longitudes should follow that convention. Doing so would allow for removal of the body rotation checks inMaRC::ViewingGeometryimplementation.Convenience wrappers, such as
MaRC::EastLongitudeandMaRC::WestLongitude, could be provided to prevent the user from inadvertently supplying an East longitude when a West longitude was expected, or vice versa.