Closed SarthakSharma660 closed 1 year ago
Will this help people to get approved there PR's?
yes i guess
Alright, You can add PR for that I'll test out if works.
Hang up to update things properly!
@mohitmishra786 Is your recent .py approved as Hacktoberfest PR?
Please let me know about that. TYSM
@mohitmishra786 Is your recent .py approved as Hacktoberfest PR?
Please let me know about that. TYSM
Anyone else
@07abhi9av
@debajyotig466
@Akshitparmar
@Stormshadows
@SarthakSharma660 It doesn't work any else way to get this repo approved?
@ossamamehmood Even mine got excluded
Could you guys find out a solution article or something to solve that?
Can you assign this to me as well? @ossamamehmood I will be really grateful to you. I have got some brilliant codes to add this in folder. My codes are in C++.
Go ahead just find a solution I'll assign you as CO-Maintainer of the repo. If you find out a solution for that particular issue EXCLUDED PRs.
@ossamamehmood I think this is due to the naming convention. people are not following the file naming convention like file-name should not have spaces in btw or some random name like"2@dsasdnfh!.extention" as these files are treated as a threat. we can try resolving the names. and please do share full ss
Can you add some files to the DSA folder I created @SarthakSharma660 accordingly?
and I also suggest that please ask to use command line only
error: invalid path 'DSA (Add Code Here)/half pyramid using *.java' fatal: unable to checkout working tree warning: Clone succeeded, but checkout failed. You can inspect what was checked out with 'git status' and retry with 'git restore --source=HEAD :/' I am getting this error while cloning the repo tried soln on stack overflow but not working
@SarthakSharma660,
I removed some codes hope it works now as the repo size is increased a lot!
Actually I'm getting a waiting period of about 7 days on the hacktoberfest official site about the recent pull request. What does that mean?
On Sat, Oct 1, 2022 at 11:32 PM Ossama Mehmood 샘 @.***> wrote:
@mohitmishra786 https://github.com/mohitmishra786 Is your recent .py approved as Hacktoberfest PR?
Please let me know about that. TYSM
Anyone else @07abhi9av https://github.com/07abhi9av @debajyotig466 https://github.com/debajyotig466 @Akshitparmar https://github.com/Akshitparmar @Stormshadows https://github.com/Stormshadows
— Reply to this email directly, view it on GitHub https://github.com/ossamamehmood/Hacktoberfest2022/issues/336#issuecomment-1264438540, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMBU5LQDCVDQFAVNALAAK3WBB4EJANCNFSM6AAAAAAQ2QN6JY . You are receiving this because you were mentioned.Message ID: @.***>
@07abhi9av nothing ur pr and repo is been analysed by hacktober fest team
even my submission says Excluded
So does that mean my pull request is approved by the maintainer?
On Sun, Oct 2, 2022 at 12:07 AM Sarthak Sharma @.***> wrote:
@07abhi9av https://github.com/07abhi9av nothing ur pr and repo is been analysed by hacktober fest team
— Reply to this email directly, view it on GitHub https://github.com/ossamamehmood/Hacktoberfest2022/issues/336#issuecomment-1264448420, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMBU5KEYFLGDTH3NCOW2IDWBCAINANCNFSM6AAAAAAQ2QN6JY . You are receiving this because you were mentioned.Message ID: @.***>
@07abhi9av It means they might approve in 7 days.
@ossamamehmood you do not make any folder let me do that
@ossamamehmood you do not make any folder let me do that
yes
@SarthakSharma660 Sure Please!
@SarthakSharma660 and @ossamamehmood can you guys help me with one more doubt?
Yes sure ask!
@ossamamehmood 56331592?v=4https:%2F%2Favatars.githubusercontent.com%2Fu%2F56331592?v=4 this file is creating some issues can you remove it or rename it? and was talking about these types of names they are treated as threats
@ossamamehmood PR/MR: 07ABHI9AV/HACKTOBERFEST2022#3
This is been showing in the waiting section. I guess it should show @ossamamehmood your name. Sorry if it's a silly question because I'm a beginner.
is this thing resolved?
I removed "56331592?v=4https:%2F%2Favatars.githubusercontent.com%2Fu%2F56331592?v=4" from the 📂!
@ossamamehmood pls see to this.
may be because of this
@07abhi9av You merge that yourself on your own fork. That's why it's been worked!
@git-dibwar Yes I know 🦋 But we want some escape for this repo lol 😂!
So there's no issue in that...right? I mean after the waiting period of 7 days these PR's won't get excluded? @ossamamehmood pls see!
Or should i send some more PR/MR so thay you can merge them. @ossamamehmood ??
Yes, It'll be approved there's a 90% chance @07abhi9av
@git-dibwar Yes I know 🦋 But we want some escape for this repo lol 😂!
So, I guess it won't get counted. Any solution for that.?.you know lot about this..
Yes, It'll be approved there's a 90% chance @07abhi9av
Thanks for your help brother.... I'm very thankful to you!! @ossamamehmood
actually, i didn't understand how to do a pull request. i forked the repo. i cloned it. but how to proceed from here? Sorry for any miscommunication. But i am newbie to this. Still trying to understand the entire github.
Haha @git-dibwar follow his pathway just fork on di change on your own end and label your own self merge your ownself!
Yes, It'll be approved there's a 90% chance @07abhi9av
Thanks for your help brother.... I'm very thankful to you!! @ossamamehmood
All mine pleasure <3
Yes, It'll be approved there's a 90% chance @07abhi9av
Thanks for your help brother.... I'm very thankful to you!! @ossamamehmood
All mine pleasure <3
I'll text you when I'll have a doubt or some help required @ossamamehmood
Sure @07abhi9av !
I removed "56331592?v=4https:%2F%2Favatars.githubusercontent.com%2Fu%2F56331592?v=4" from the 📂!
@SarthakSharma660 ?
Sure @07abhi9av !
Can I get your some personal mail Id or any other place to text you personally? @ossamamehmood
I removed "56331592?v=4https:%2F%2Favatars.githubusercontent.com%2Fu%2F56331592?v=4" from the 📂!
@SarthakSharma660 ?
I was the culprit for me now I am working on it
Sure @07abhi9av !
Can I get your personal mail Id or any other place to text you personally? @ossamamehmood
You can reach out anywhere @ossamamehmood110@gmail.com OR linkedin.com/in/ossamamehmood
I removed "56331592?v=4https:%2F%2Favatars.githubusercontent.com%2Fu%2F56331592?v=4" from the 📂!
@SarthakSharma660 ?
I was the culprit for me now I am working on it
Aright @SarthakSharma660
BAD REPOSITORIES WILL BE EXCLUDED. PR/MRs should be useful to maintainers. Repos that encourage simplistic PR/MRs (like adding a name or profile to a list or arbitrarily curating content) will be excluded from Hacktoberfest. Remember: quantity is fun, quality is key.
can you make a new repository where some proper contributions can be done without any such exclusion rules
May I add a DSA Folder in the repo with a few c# codes?