Closed michaelpq closed 1 year ago
@rjuju @yamatattsu @horiguti @MasahikoSawada If there are no objections from any of you, do you mind if I apply this patch and fix the regression tests? I have other patches brewing on top of that that would need more careful review.
Hearing nothing, I have applied this one to stabilize the branch.
Upstream PostgreSQL has removed support for SELECT ON rules for all relation types except views in b23cd18, impacting PostgreSQL 16. The regression tests of pg_hint_plan had some tests that depended on such rules to make sure that hints are working correctly when a table is rewritten as a view, introduced in 1bbcfa2.
Now that PostgreSQL does not support this scenario, there is no need to worry about these in pg_hint_plan, either, so let's remove these tests. This counted for roughly 30% of the noise still in regression.diffs when running the regression tests.