search

ossc-db / pg_hint_plan

Extension adding support for optimizer hints in PostgreSQL
Other
674 stars 101 forks source link

Fix warnings when building sphinx #149

Closed mikecaat closed 10 months ago

michaelpq commented 10 months ago

In your second patch, the commit message mention pgsql, but it should be plpgsql.

michaelpq commented 10 months ago

Splitting into 3 commits is OK for the review, perhaps, but let's just merge everything into a single commit at the end. Please feel free to go ahead and apply them down to 14.

mikecaat commented 10 months ago

Thanks for the review. I have merged them into a single commit and updated the commit messages. If you're ok, I'll apply it down to 14. BTW, this will be the first time I apply to the upstream repository directory.

michaelpq commented 10 months ago

If you're ok, I'll apply it down to 14. BTW, this will be the first time I apply to the upstream repository directory.

No problem. Go ahead :)

mikecaat commented 10 months ago

Thanks! I've pushed it to master, PG15 and PG14 branches.

mikecaat commented 10 months ago

Also pushed to PG16.