search

ossc-db / pg_rman

Backup and restore management tool for PostgreSQL
http://ossc-db.github.io/pg_rman/index.html
Other
476 stars 77 forks source link

Get the correct increment backup #176

Closed huangfumingyue closed 3 years ago

huangfumingyue commented 3 years ago

Before, we actually got the difference backup, not the incremental backup. TO solve this probem ,revert #125.

However, if a physical backup file is deleted(rm command, etc.) other than the pg_rman delete command of pg_rman, It cannot find the correct status of a full backup and incremental backup.(please refer to #154 to details) WE will solve this problem, at the next major upgarde.

MoonInsung commented 3 years ago

And, please add a regression test. Currently, there are no tests to verify that incremental backups have been acquired normally. Therefore, please add a test to check the size of the incremental backup.

MoonInsung commented 3 years ago

Dear @huangfumingyue , @mikecaat

Thank you for the response and review!!

I think Issues related to incremental backups remain(#154) but like this PR, (1) Rollback of commits related to incremental backup (2) Add comments on the problems related to incremental backup (3) Add regression test related to incremental backup We need to deal with the most urgent problems like #150.

So, I look good about the modified PR.

If, don't have any opinion, I'll commit it aroud 15:00(JST) on May 28. Also, I'll do a back-patch REL_9_6_STABLE to REL_13_STABLE for these PR commits.

Best regards. Moon.