Fix removing 'include' logic when restoring #216

ossc-db / pg_rman

Backup and restore management tool for PostgreSQL

http://ossc-db.github.io/pg_rman/index.html

Other

476 stars 77 forks source link

Fix removing 'include' logic when restoring #216 #217

Closed mikecaat closed 2 years ago

mikecaat commented 2 years ago

When restoring, pg_rman removes the 'include' directive which it previously added in the restored postgrsql.conf.

But, the logic didn't consider the restored data doesn't have postgresql.conf. It happens when a user manages it in a directory different from the data directory using postgresql's guc parameter data_directory.

mikecaat commented 2 years ago

But, to use data_directory is not recommended because recovery-relate parameters (ex. --recovery-target-time) don't work. It must add them into postgresql.conf which user manages, but it add them into postgresql.conf in the restored data directory.

mikecaat commented 2 years ago

TODO

apply another branch(ex. master branch)
add a description about the option to the document in master branch.

mikecaat commented 2 years ago

[memo] As a first step, this commit omits following feature.

manage the config path in pg_rman catalog file
check the config path and know PGDATA(data_directory), ARCIVE_PATH and SRVLOG_PATH when to init

huangfumingyue commented 2 years ago

It looks good. And I think that the new option needs to be added to the manual.