fix the range of keep data generation

ossc-db / pg_rman

Backup and restore management tool for PostgreSQL

http://ossc-db.github.io/pg_rman/index.html

Other

476 stars 77 forks source link

fix the range of keep data generation #218

Open huangfumingyue opened 2 years ago

huangfumingyue commented 2 years ago

If you set keep_data_generations = 0, the backup you got will be deleted immediately, I think the setting like keep_data_generations = 0 is meaningless. So, In this PR, the minimum value of the setting range of keep_data_generations has been changed to 1. In addition, keep_srvlog_days, keep_srvlog_files have been modified in the same way.

mikecaat commented 2 years ago

Hi, thanks for making the PR. I have some comments.

Is there any reason that you didn't change other keep-* parameters (ex. keep-data-days)?
Is it better use parse_uint32() in parse_posi()?
Though I'm not confident, is it good to add parse_posi() in pguc.c because it seems that the function only returns primitive data types? Is it better to use 'f' option?

mikecaat commented 2 years ago

In the first place, I got not to be confidence that we must check if the values are zero because the users may want to remove the backup files.