search

ossc-db / pg_rman

Backup and restore management tool for PostgreSQL
http://ossc-db.github.io/pg_rman/index.html
Other
476 stars 77 forks source link

fix typo #221

Closed huangfumingyue closed 2 years ago

huangfumingyue commented 2 years ago

bash-4.4$ pg_rman restore --recovery-target-time '2022-03-15 02:24:122' bash-4.4$ /usr/pgsql-14/bin/pg_rman restore --recovery-target-time '2022-03-15 0 2:24:122' ERROR: could not create recovery.conf oradd recovery-related options to postgres ql.conf(after PG12) with 2022-03-15 02:24:122

I think the message [ERROR: could not create recovery.conf or add recovery-related options to postgres ql.conf(after PG12) with ] is right.

oradd →　or add

mikecaat commented 2 years ago

Thanks, I agree.

I have two comments.

(1)

There are four same mistakes in checkIfCreateRecoveryConf(). Is it better change all of them?

(2)

Is it better to move the location of space to after the "or" to correspond to the PostgreSQL code style?

# before "add"
                 errmsg("could not create recovery.conf or"
                        " add recovery-related options to postgresql.conf(after PG12) with %s", target_xid)));
# after "or"
                 errmsg("could not create recovery.conf or "
                        "add recovery-related options to postgresql.conf(after PG12) with %s", target_xid)));
huangfumingyue commented 2 years ago

Thanks, I updated it.

mikecaat commented 2 years ago

Thanks, it looks good to me.