search

ossc-db / pg_rman

Backup and restore management tool for PostgreSQL
http://ossc-db.github.io/pg_rman/index.html
Other
476 stars 77 forks source link

To support PostgreSQL v15 #229

Open zwyan0 opened 2 years ago

zwyan0 commented 2 years ago

To support PostgreSQL15

mikecaat commented 2 years ago

Thanks!

zwyan0 commented 2 years ago

Thanks for your works!

Although I have some comments, it's ok after the RC version is released because it's trivial things.

Please add commit message the deatailed reason why you change the code because mainteners may change. For example, I think the following things are important.

  • why do we change to pg_backup_start()/pg_backup_stop() and the arguments are changed? In my understanding, though the exclusive mode is remove, it just renames the function name and keeps the behavior because pg_rman already changed to use non-exclusive mode.
  • why the arc_srv_log_management.sh change the log_checkpoints = off? In my undersanding, the reason is that the test to check if the expected server logs are removed fails since the default value bacame 'on'. The checkpoint logs update the timestamp of server log files when executing the test, and it makes remove newer dummy server logs. To avoid the behavior, turn it off only when the tests are executed.

I changed commit message.

tdchi commented 1 year ago

Hello. When will the pg_rman source be released to support PG15?

zwyan0 commented 1 year ago

Hello. When will the pg_rman source be released to support PG15?

Hello. I can't give you an exact time, but we will try to release it as soon as possible.