Several fixes on recent changes

ossc-db / pg_store_plans

Store execution plans like pg_stat_statements does for queries.

http://ossc-db.github.io/pg_store_plans/

Other

53 stars 26 forks source link

Several fixes on recent changes #19

Closed horiguti closed 2 years ago

horiguti commented 2 years ago

As Julien pointed, the new GUC plan_storage shouldbe PGC_POSTMASTER(1), and we should use Int64GetDatum(Fast) for queryid since it is an int64. On the way fixing it I noticed that Int64GetDatumFast is fed with a constant, which is not the proper use. Actually build fails for !USE_FLOAT_BYVAL servers. Fix them together (2). Finally, I'm not sure how come I pushed that with that state, but compiler complains about some uninitialized variables so fix it(3).

horiguti commented 2 years ago

I'll push this tomorrow if there's no comments.

rjuju commented 2 years ago

Sorry for the late reply. Apart from one minor detail the rest of the patch looks good to me!

horiguti commented 2 years ago

Done. Thanks!

rjuju commented 2 years ago

Thanks a lot!