PostgreSQL 16 support

[devrimgunduz]

Hi,

Latest release does not build against PostgreSQL 16. Errors are below. Can you please take a look? v16 is due this week.

Regards, Devrim

/usr/lib64/ccache/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Xclang -no-opaque-pointers -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -O2 -I. -I./ -I/usr/pgsql-16/include/server -I/usr/pgsql-16/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include -flto=thin -emit-llvm -c -o pgsp_explain.bc pgsp_explain.c pgsp_json.c:19:10: fatal error: parser/gram.h: No such file or directory 19 | #include "parser/gram.h" | ^~~~~~~ compilation terminated. make[1]: [: pgsp_json.o] Error 1 make[1]: Waiting for unfinished jobs.... pgsp_json.c:19:10: fatal error: 'parser/gram.h' file not found

include "parser/gram.h"

^~~~~~~ pgsp_json_text.c:1019:25: error: incompatible function pointer types assigning to 'json_struct_action' (aka 'enum JsonParseErrorType ()(void )') from 'void (void )' [-Wincompatible-function-pointer-types] sem.object_start = json_text_objstart; ^ ~~~~~~ pgsp_json_text.c:1020:25: error: incompatible function pointer types assigning to 'json_struct_action' (aka 'enum JsonParseErrorType ()(void )') from 'void (void )' [-Wincompatible-function-pointer-types] sem.object_end = json_text_objend; ^ ~~~~ pgsp_json_text.c:1021:25: error: incompatible function pointer types assigning to 'json_struct_action' (aka 'enum JsonParseErrorType ()(void )') from 'void (void )' [-Wincompatible-function-pointer-types] sem.array_start = json_text_arrstart; ^ ~~~~~~ pgsp_json_text.c:1022:25: error: incompatible function pointer types assigning to 'json_struct_action' (aka 'enum JsonParseErrorType ()(void )') from 'void (void )' [-Wincompatible-function-pointer-types] sem.array_end = json_text_arrend; ^ ~~~~ pgsp_json_text.c:1023:25: error: incompatible function pointer types assigning to 'json_ofield_action' (aka 'enum JsonParseErrorType ()(void , char , bool)') from 'void (void , char , bool)' [-Wincompatible-function-pointer-types] sem.object_field_start = json_text_ofstart; ^ ~~~~~ pgsp_json_text.c:1024:25: error: incompatible function pointer types assigning to 'json_ofield_action' (aka 'enum JsonParseErrorType ()(void , char , bool)') from 'void (void , char , bool)' [-Wincompatible-function-pointer-types] sem.object_field_end = json_text_ofend; ^ ~~~ pgsp_json_text.c:1027:25: error: incompatible function pointer types assigning to 'json_scalar_action' (aka 'enum JsonParseErrorType ()(void , char , enum JsonTokenType)') from 'void (void , char , JsonTokenType)' (aka 'void (void , char *, enum JsonTokenType)') [-Wincompatible-function-pointer-types] sem.scalar = json_text_scalar; ^ ~~~~ 7 errors generated. make[1]: [/usr/pgsql-16/lib/pgxs/src/makefiles/../../src/Makefile.global:1080: pgsp_json_text.bc] Error 1 1 error generated. make[1]: [/usr/pgsql-16/lib/pgxs/src/makefiles/../../src/Makefile.global:1080: pgsp_json.bc] Error 1 pg_store_plans.c:57:10: fatal error: utils/queryjumble.h: No such file or directory 57 | #include "utils/queryjumble.h" | ^~~~~ compilation terminated. make[1]: *** [: pg_store_plans.o] Error 1 pg_store_plans.c:57:10: fatal error: 'utils/queryjumble.h' file not found

include "utils/queryjumble.h"

^~~~~ 1 error generated. make[1]: ** [/usr/pgsql-16/lib/pgxs/src/makefiles/../../src/Makefile.global:1080: pg_store_plans.bc] Error 1 pgsp_json_text.c: In function 'pgsp_json_textize': pgsp_json_text.c:1019:32: warning: assignment to 'json_struct_action' {aka 'JsonParseErrorType ()(void )'} from incompatible pointer type 'void ()(void )' [-Wincompatible-pointer-types] 1019 | sem.object_start = json_text_objstart; | ^ pgsp_json_text.c:1020:32: warning: assignment to 'json_struct_action' {aka 'JsonParseErrorType ()(void )'} from incompatible pointer type 'void ()(void )' [-Wincompatible-pointer-types] 1020 | sem.object_end = json_text_objend; | ^ pgsp_json_text.c:1021:32: warning: assignment to 'json_struct_action' {aka 'JsonParseErrorType ()(void )'} from incompatible pointer type 'void ()(void )' [-Wincompatible-pointer-types] 1021 | sem.array_start = json_text_arrstart; | ^ pgsp_json_text.c:1022:32: warning: assignment to 'json_struct_action' {aka 'JsonParseErrorType ()(void )'} from incompatible pointer type 'void ()(void )' [-Wincompatible-pointer-types] 1022 | sem.array_end = json_text_arrend; | ^ pgsp_json_text.c:1023:32: warning: assignment to 'json_ofield_action' {aka 'JsonParseErrorType ()(void , char , _Bool)'} from incompatible pointer type 'void ()(void , char , _Bool)' [-Wincompatible-pointer-types] 1023 | sem.object_field_start = json_text_ofstart; | ^ pgsp_json_text.c:1024:32: warning: assignment to 'json_ofield_action' {aka 'JsonParseErrorType ()(void , char , _Bool)'} from incompatible pointer type 'void ()(void , char , _Bool)' [-Wincompatible-pointer-types] 1024 | sem.object_field_end = json_text_ofend; | ^ pgsp_json_text.c:1027:32: warning: assignment to 'json_scalar_action' {aka 'JsonParseErrorType ()(void , char , JsonTokenType)'} from incompatible pointer type 'void ()(void , char *, JsonTokenType)' [-Wincompatible-pointer-types] 1027 | sem.scalar = json_text_scalar; | ^ make[1]: Leaving directory '/home/devrim/Documents/Devrim/Projects/repo/pgrpms/rpm/redhat/main/non-common/pg_store_plans/main/pg_store_plans-1.7' error: Bad exit status from /var/tmp/rpm-tmp.oD0QRP (%build)

[devrimgunduz]

ping

[devrimgunduz]

ping

[LevNikolaev]

https://github.com/ossc-db/pg_store_plans/pull/31